Annikka/evennia
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Refactor to remove alerts as per lgtm and #1176.

Browse source 
Should remove 2 string concatenation in a loop alerts.
This commit is contained in:
BlauFeuer 2017-02-17 18:18:37 -05:00 • committed by GitHub
parent ad1b0c7b77
commit a651490565
1 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

12
evennia/contrib/barter.py
View file

@ -655,23 +655,23 @@ class CmdStatus(CmdTradeBase):
caller = self.caller caller = self.caller
part_a_offers, part_b_offers = self.tradehandler.list() part_a_offers, part_b_offers = self.tradehandler.list()
count = 1 count = 1
part_a_offerlist = "" part_a_offerlist = []
for offer in part_a_offers: for offer in part_a_offers:
part_a_offerlist += "\n |w%i|n %s" % (count, offer.key) part_a_offerlist.append("\n |w%i|n %s" % (count, offer.key))
count += 1 count += 1
if not part_a_offerlist: if not part_a_offerlist:
part_a_offerlist = "\n <nothing>" part_a_offerlist = "\n <nothing>"
part_b_offerlist = "" part_b_offerlist = []
for offer in part_b_offers: for offer in part_b_offers:
part_b_offerlist += "\n |w%i|n %s" % (count, offer.key) part_b_offerlist.append("\n |w%i|n %s" % (count, offer.key))
count += 1 count += 1
if not part_b_offerlist: if not part_b_offerlist:
part_b_offerlist = "\n <nothing>" part_b_offerlist = "\n <nothing>"
string = "|gOffered by %s:|n%s\n|yOffered by %s:|n%s" % (self.part_a.key, string = "|gOffered by %s:|n%s\n|yOffered by %s:|n%s" % (self.part_a.key,
part_a_offerlist, "".join(part_a_offerlist),
self.part_b.key, self.part_b.key,
part_b_offerlist) "".join(part_b_offerlist))
accept_a = self.tradehandler.part_a_accepted and "|gYes|n" or "|rNo|n" accept_a = self.tradehandler.part_a_accepted and "|gYes|n" or "|rNo|n"
accept_b = self.tradehandler.part_b_accepted and "|gYes|n" or "|rNo|n" accept_b = self.tradehandler.part_b_accepted and "|gYes|n" or "|rNo|n"
string += "\n\n%s agreed: %s, %s agreed: %s" % (self.part_a.key, accept_a, self.part_b.key, accept_b) string += "\n\n%s agreed: %s, %s agreed: %s" % (self.part_a.key, accept_a, self.part_b.key, accept_b)