Annikka/evennia
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Made evadventure unit tests pass again

Browse source
This commit is contained in:
Griatch 2023-05-19 20:41:10 +02:00
parent 2a75ea8343
commit 431d1d85cb
3 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

6
docs/source/Howtos/Beginner-Tutorial/Part3/Beginner-Tutorial-Objects.md
View file

@ -259,7 +259,7 @@ def at_pre_use(self, user, target=None, *args, **kwargs):
user.msg("You are not close enough to the target!") user.msg("You are not close enough to the target!")
return False return False
if self.quality <= 0: if self.quality is not None and self.quality <= 0:
user.msg(f"{self.get_display_name(user)} is broken and can't be used!") user.msg(f"{self.get_display_name(user)} is broken and can't be used!")
return False return False
return super().at_pre_use(user, target=target, *args, **kwargs) return super().at_pre_use(user, target=target, *args, **kwargs)
@ -309,13 +309,13 @@ def at_pre_use(self, user, target=None, *args, **kwargs):
location.msg_contents(message, from_obj=attacker, mapping={target.key: target}) location.msg_contents(message, from_obj=attacker, mapping={target.key: target})
def at_post_use(self, user, *args, **kwargs): def at_post_use(self, user, *args, **kwargs):
if self.quality <= 0: if self.quality is not None and self.quality <= 0:
user.msg(f"|r{self.get_display_name(user)} breaks and can no longer be used!") user.msg(f"|r{self.get_display_name(user)} breaks and can no longer be used!")
``` ```
In EvAdventure, we will assume all weapons (including bows etc) are used in the same location as the target. Weapons also have a `quality` attribute that gets worn down if the user rolls a critical failure. Once quality is down to 0, the weapon is broken and needs to be repaired. In EvAdventure, we will assume all weapons (including bows etc) are used in the same location as the target. Weapons also have a `quality` attribute that gets worn down if the user rolls a critical failure. Once quality is down to 0, the weapon is broken and needs to be repaired.
The `quality` is something we need to track in _Knave_. When getting critical failures on attacks, a weapon's quality will go down. When it reaches 0, it will break. The `quality` is something we need to track in _Knave_. When getting critical failures on attacks, a weapon's quality will go down. When it reaches 0, it will break. We assume that a `quality` of `None` means that quality doesn't apply (that is, the item is unbreakable), so we must consider that when checking.
The attack/defend type tracks how we resolve attacks with the weapon, like `roll + STR vs ARMOR + 10`. The attack/defend type tracks how we resolve attacks with the weapon, like `roll + STR vs ARMOR + 10`.

4
evennia/contrib/tutorials/evadventure/objects.py
View file

@ -213,7 +213,7 @@ class EvAdventureWeapon(EvAdventureObject):
user.msg("You are not close enough to the target!") user.msg("You are not close enough to the target!")
return False return False
if self.quality <= 0: if self.quality is not None and self.quality <= 0:
user.msg(f"{self.get_display_name(user)} is broken and can't be used!") user.msg(f"{self.get_display_name(user)} is broken and can't be used!")
return False return False
return super().at_pre_use(user, target=target, *args, **kwargs) return super().at_pre_use(user, target=target, *args, **kwargs)
@ -263,7 +263,7 @@ class EvAdventureWeapon(EvAdventureObject):
location.msg_contents(message, from_obj=attacker, mapping={target.key: target}) location.msg_contents(message, from_obj=attacker, mapping={target.key: target})
def at_post_use(self, user, *args, **kwargs): def at_post_use(self, user, *args, **kwargs):
if self.quality <= 0: if self.quality is not None and self.quality <= 0:
user.msg(f"|r{self.get_display_name(user)} breaks and can no longer be used!") user.msg(f"|r{self.get_display_name(user)} breaks and can no longer be used!")

4
evennia/contrib/tutorials/evadventure/tests/test_rooms.py
View file

@ -48,7 +48,7 @@ Exits: north, northeast, east, southeast, south, southwest, west, and northwest"
result = "\n".join(part.rstrip() for part in strip_ansi(desc).split("\n")) result = "\n".join(part.rstrip() for part in strip_ansi(desc).split("\n"))
expected = "\n".join(part.rstrip() for part in expected.split("\n")) expected = "\n".join(part.rstrip() for part in expected.split("\n"))
print(result) # print(result)
print(expected) # print(expected)
self.assertEqual(result, expected) self.assertEqual(result, expected)