Made unittesting suite work again.

src/objects/models.py

@@ -374,15 +374,8 @@ class ObjectDB(TypedObject):
             return self.typeclass
 
         if use_nicks:
-            # get all valid nicks to search
-            nicks = self.nicks.get(category="object")
-            if self.has_player:
-                pnicks = self.nicks.get(category="player")
-                nicks = nicks + pnicks
-            for nick in nicks:
-                if searchdata == nick.db_key:
-                    searchdata = nick.strvalue
-                    break
+            # do nick-replacement on search
+            searchdata = self.nicks.nickreplace(searchdata, categories=("object", "player"), include_player=True)
 
         candidates=None
         if(global_search or (is_string and searchdata.startswith("#") and

src/players/models.py

@@ -424,7 +424,7 @@ class PlayerDB(TypedObject, AbstractUser):
         # nick replacement - we require full-word matching.
 
         raw_string = utils.to_unicode(raw_string)
-        raw_string = self.nicks.nickreplacement(raw_string,
+        raw_string = self.nicks.nickreplace(raw_string,
                           categories=("inputline", "channels"), include_player=False)
         if not sessid and _MULTISESSION_MODE in (0, 1):
             # in this case, we should either have only one sessid, or the sessid

src/typeclasses/models.py

@@ -400,11 +400,10 @@ class NickHandler(AttributeHandler):
 
     def nickreplace(self, raw_string, categories=("inputline", "channels"), include_player=True):
         "Replace entries in raw_string with nick replacement"
-        obj_nicks = []
+        obj_nicks, player_nicks = [], []
         for category in make_iter(categories):
             obj_nicks.extend(make_iter(self.get(category=category, return_obj=True)))
         if include_player and self.obj.has_player:
-            player_nicks = []
             for category in make_iter(categories):
                 player_nicks.extend(make_iter(self.obj.player.nicks.get(category=category, return_obj=True)))
         for nick in obj_nicks + player_nicks: