From 04b72cbe91a5e4ae9d6b82e8c099177921ca69c2 Mon Sep 17 00:00:00 2001 From: Henddher Pedroza Date: Wed, 16 Oct 2019 20:45:53 -0400 Subject: [PATCH] Increase coverage for evennia/utils/validatorfuncs.unsigned_integer and .positive_integer. --- evennia/utils/tests/test_validatorfuncs.py | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/evennia/utils/tests/test_validatorfuncs.py b/evennia/utils/tests/test_validatorfuncs.py index 30231c5e6..becf4ffb0 100644 --- a/evennia/utils/tests/test_validatorfuncs.py +++ b/evennia/utils/tests/test_validatorfuncs.py @@ -84,21 +84,27 @@ class TestValidatorFuncs(TestCase): @mock.patch('builtins.int') def test_positive_integer_raises_ValueError(self, mocked_int): + mocked_int.return_value = -1 + with self.assertRaises(ValueError): + validatorfuncs.positive_integer(str(-1)) for pi in ['', '000', 'abc', '-1']: mocked_int.side_effect = ValueError with self.assertRaises(ValueError): validatorfuncs.positive_integer(pi) def test_unsigned_integer_ok(self): - for ui in ['123', '4567890', '001']: + for ui in ['123', '4567890', '001', '0']: self.assertEqual(int(ui), validatorfuncs.unsigned_integer(ui)) @mock.patch('builtins.int') def test_unsigned_integer_raises_ValueError(self, mocked_int): + mocked_int.return_value = -1 + with self.assertRaises(ValueError): + validatorfuncs.unsigned_integer(str(-1)) for ui in ['', '000', 'abc', '-1', '0']: mocked_int.side_effect = ValueError with self.assertRaises(ValueError): - validatorfuncs.signed_integer(ui) + validatorfuncs.unsigned_integer(ui) def test_boolean(self): for b in ['true', '1', 'on', 'ENABLED']: